fix(CheckboxGroup): add label and description to theme slots#6453
fix(CheckboxGroup): add label and description to theme slots#6453OfirHaf wants to merge 1 commit into
Conversation
CheckboxGroupSlots defines label and description slots (forwarded to each inner Checkbox), but the theme only declared root, fieldset, legend, and item — making label/description invisible to app.config.ts type checking even though they work correctly at runtime. Added label and description with the same default classes used in checkbox.ts and radio-group.ts (the sibling components). Fixes nuxt#6337
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates the CheckboxGroup theme configuration by expanding the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/theme/checkbox-group.tsParsing error: Unexpected token { Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Fixes #6337
Problem
CheckboxGroupSlotsdefineslabelanddescriptionslots (they are forwarded to each innerCheckbox), butsrc/theme/checkbox-group.tsonly declaresroot,fieldset,legend, anditem.This means customising via
app.config.tsthrows a type error:...even though it works correctly at runtime.
Fix
Add
labelanddescriptionto theslotsmap with the same default classes already used incheckbox.tsandradio-group.ts:Why it's safe
Checkbox,RadioGroup)