Skip to content

feat: add jasy to modules#1532

Merged
danielroe merged 4 commits into
nuxt:mainfrom
Flo0806:feat/jasy-pdf
Jul 22, 2026
Merged

feat: add jasy to modules#1532
danielroe merged 4 commits into
nuxt:mainfrom
Flo0806:feat/jasy-pdf

Conversation

@Flo0806

@Flo0806 Flo0806 commented Jun 27, 2026

Copy link
Copy Markdown
Member

📚 Description

jasy is a pure TS PDF renderer, including XRechnung and ZUGFeRD. It renders on browser and on server site. This module let jasy use the power of Nuxt and Nitro.

Would love to see it in the store ❤️

https://jasy.dev

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09d952b2-c194-4783-8354-1d6a083b0b2a

📥 Commits

Reviewing files that changed from the base of the PR and between ff25383 and 64025be.

📒 Files selected for processing (1)
  • modules/pinia-orm.yml

📝 Walkthrough

Walkthrough

Adds a new modules/jasy.yml entry with module metadata, links, classification, maintainer information, and Nuxt compatibility requirements. Updates modules/pinia-orm.yml to require Nuxt >=3.14.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding jasy to the modules list.
Description check ✅ Passed The description is directly related to the PR and describes jasy and its Nuxt module intent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
modules/pinia-orm.yml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@modules/jasy.yml`:
- Line 3: The module config is embedding branch/subdir information inside the
repo value, but the parser in lib/modules.ts strips everything after the hash so
the subdirectory is lost. Update this module entry to use explicit repo and
subdir fields instead of encoding both in repo, or adjust the parser if that is
the intended format, so the checkout location is preserved.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 213040ae-232c-42a3-aaa0-d8ab68734282

📥 Commits

Reviewing files that changed from the base of the PR and between 48c8b18 and 17b6fd0.

⛔ Files ignored due to path filters (1)
  • icons/jasy.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • modules/jasy.yml

Comment thread modules/jasy.yml
@danielroe
danielroe merged commit 6ddbc7f into nuxt:main Jul 22, 2026
6 checks passed
@Flo0806
Flo0806 deleted the feat/jasy-pdf branch July 22, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants