fix: remove duplicated provider key in generated image options#2279
fix: remove duplicated provider key in generated image options#2279DamianGlowala wants to merge 1 commit into
provider key in generated image options#2279Conversation
commit: |
Deploying nuxt-image with
|
| Latest commit: |
82b9d0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f25691a5.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-duplicate-provider-key.nuxt-image.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 7 7
Lines 371 371
Branches 131 131
=======================================
Hits 121 121
Misses 194 194
Partials 56 56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📝 WalkthroughWalkthrough
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/module.ts`:
- Around line 238-246: Update the generated `imageOptions` template in the
serialization flow around `serializedImageOptions` so the comma after its
interpolated entries is emitted only when non-`provider` fields exist. Preserve
valid output when `imageOptions` contains only `provider`, while retaining
separators for configurations with serialized entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
🔗 Linked issue
resolves #2242
📚 Description
Removes duplicated
providerkey in generated image options and slightly adjusts formatting.