Skip to content

test(network): fix flaky Test_conn_startSending #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenvegt wants to merge 1 commit into
base: V5.4
Choose a base branch
from
Open

test(network): fix flaky Test_conn_startSending #4431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions network/transport/grpc/connection_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,17 @@ func Test_conn_startSending(t *testing.T) {

assert.Equal(t, int32(2), connection.activeGoroutines) // startSending and startReceiving

stream.cancelFunc()
// Disconnect before cancelling the stream: this guarantees the connection context is
// cancelled before RecvMsg returns, so the receive loop drops the message instead of
// racing to store the stream error as close status.
connection.disconnect()
stream.cancelFunc()

test.WaitFor(t, func() (bool, error) {
return atomic.LoadInt32(&connection.activeGoroutines) == 0, nil
}, 5*time.Second, "waiting for all goroutines to exit")

// Last received message is dropped and no status is set. Default value is OK.
// A deliberate local disconnect must not record a close error. Default value is OK.
assert.Equal(t, codes.OK, connection.status.Load().Code())
})
}
Expand Down
Loading