fix(http): strict-mode SSRF guard (#4420) and docs (#4423) - #4424
Open
stevenvegt wants to merge 3 commits into
Open
fix(http): strict-mode SSRF guard (#4420) and docs (#4423)#4424stevenvegt wants to merge 3 commits into
stevenvegt wants to merge 3 commits into
Conversation
Fixes potential SSRF vulnerability by preventing the internal http client of connecting to a curated IANA list of prohibited (internal) endpoints/ip ranges. This check is executed at the transport layer just after IP lookup so we don't rely on DNS. An administrator has the config options to allow or deny additional ip ranges. See #4420 for additional info. Assisted-by: AI
Add an SSRF section to the security considerations page explaining the strict-mode outbound guard and how to configure allowedinternalcidrs and deniedcidrs in production. Link to it from the release notes entry. Assisted-by: AI
stevenvegt
requested review from
gerardsn,
reinkrul and
woutslakhorst
as code owners
July 27, 2026 15:05
Contributor
0 new issues
|
* test(storage): fix flaky minimemcached nil-pointer panic The minimemcached test server spawns a goroutine that calls Accept() on its listener, while Close() nils that listener. On very short tests the cleanup's Close() could run before the goroutine entered Accept(), dereferencing a nil listener inside the dependency and crashing the test binary with a panic that no test can recover (it runs in a foreign goroutine). Block in the test helper until the server answers a probe connection, guaranteeing the accept loop is parked in Accept() before the test proceeds. Close() then unblocks it cleanly instead of racing startup. Assisted by AI * test(storage): link upstream issue for the minimemcached workaround Reference daangn/minimemcached#14 (fix in PR #13) so the workaround can be removed once an upstream release ships the fix. Assisted by AI
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (4)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
Dirklectisch
approved these changes
Jul 28, 2026
stevenvegt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Backport of #4420 (strict-mode SSRF dial guard) and #4423 (deployment documentation) to V6.2, as two cherry-picked commits.
http.client.allowedinternalcidrsandhttp.client.deniedcidrs(denied takes precedence; the built-in metadata blocks cannot be re-admitted).Conflict resolution notes
The code applied cleanly. Conflicts were limited to:
go.mod/go.sum: re-added the test-only dependencycode.dny.dev/ssrf v0.3.0(drift test against the IANA registries) on top of the V6.2 dependency set.docs/pages/deployment/server_options.rst: regenerated withgo run ./docs docs(column widths reflow, so the textual diff is large; content-wise only the two new options are added).docs/pages/release_notes.rst: added anUnreleasedsection containing only the fix(http): block SSRF to non-public addresses in strict mode #4420 security bullet.Testing
go build ./...andgo test ./http/...pass locally on this branch, including the drift test and the engine-level config plumbing tests.