Skip to content

#4063: Enable storage.debug flag to enable go-leia performance logging#4064

Open
reinkrul wants to merge 6 commits intoV5.4from
iss4063-leia-index-stats
Open

#4063: Enable storage.debug flag to enable go-leia performance logging#4064
reinkrul wants to merge 6 commits intoV5.4from
iss4063-leia-index-stats

Conversation

@reinkrul
Copy link
Member

@reinkrul reinkrul commented Mar 16, 2026

Fixes #4063 for v5.4

TODO:

  • Update to released version of go-leia

Later:

  • Port to master branch

@qltysh
Copy link

qltysh bot commented Mar 16, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on V5.4 by 0.06%.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: C Coverage rating: C
vcr/vcr.go100.0%
Coverage rating: B Coverage rating: C
storage/engine.go50.0%42-44, 123-141
Coverage rating: B Coverage rating: B
vcr/issuer/leia_store.go100.0%
Coverage rating: F Coverage rating: F
storage/cmd/cmd.go0.0%42
Coverage rating: B Coverage rating: B
vcr/verifier/leia_store.go100.0%
Total52.6%
🤖 Increase coverage with AI coding...

In the `iss4063-leia-index-stats` branch, add test coverage for this new code:

- `storage/cmd/cmd.go` -- Line 42
- `storage/engine.go` -- Lines 42-44 and 123-141

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@reinkrul reinkrul requested a review from stevenvegt March 17, 2026 07:48
@reinkrul reinkrul marked this pull request as ready for review March 17, 2026 07:48
Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinks to look at:

  • encapsulate the creation of the leia store in a function which always automagically adds the callback depending on the config
  • Use the latest 0.8.0 version of json-gold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants