non-blocking completions in reedline#1093
Open
philocalyst wants to merge 3 commits into
Open
Conversation
|
|
||
| // When a background completion finishes, re-populate the active | ||
| // menu so results appear without waiting for another keypress. | ||
| if self.completer.check_pending() { |
Collaborator
There was a problem hiding this comment.
You could move the
let completer_pending = self.completer.has_pending();up here and then gate it with:
if completer_pending && self.completer.check_pending() {...}and reuse it in needs_polling.
This was the gating I was thinking of.
For both to default to false its not a deal breaker but it is cleaner this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to the respective nushell change.
Adds primitives for non-blocking completions.