Fix to yaml examples 0115 - #2228
Open
maxim-uvarov wants to merge 2 commits into
Open
Conversation
Both snippets do not match what Nushell 0.115.0 actually does.
`--non-roundtrip` takes a string, so a bare `null` is parsed as the
`null` literal and the line fails to parse:
Error: nu::parser::parse_mismatch_with_full_string_msg
x Parse mismatch: expected string.
Quoting it makes the example run and print `null` as documented.
The `--indent 4 --quote double` example showed output with 2-space
indentation and single quotes. The real output on 0.115.0 is:
outer:
inner: "value"
which is also what the two flags are there to demonstrate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two to yaml examples in the 0.115.0 release notes
Both snippets do not match what Nushell 0.115.0 actually does.
--non-roundtriptakes a string, so a barenullis parsed as thenullliteral and the line fails to parse:Quoting it makes the example run and print
nullas documented.The
--indent 4 --quote doubleexample showed output with 2-spaceindentation and single quotes. The real output on 0.115.0 is:
which is also what the two flags are there to demonstrate.