Fix Authorization & Refactor of utils#95
Open
chrischansonichu wants to merge 8 commits intonurdtechie98:devfrom
Open
Fix Authorization & Refactor of utils#95chrischansonichu wants to merge 8 commits intonurdtechie98:devfrom
chrischansonichu wants to merge 8 commits intonurdtechie98:devfrom
Conversation
…calling authorization using downloaded oauth json files properly.
chrischansonichu
requested review from
NightWing1998,
inishchith,
nurdtechie98 and
shivam1708
as code owners
… regardless of new authorization or if using the saved token.
Author
|
This additionally changes all of the config locations to |
…README for authorization instructions.
…exists checking, and giving the user clearer messages regarding failures.
…ng an error advising the user to first log in, any time a method is called.
…re supposed to be JSON files. Add check for '.history' as a file rather than a directory.
…edService if there is no token.json file present in the config directory. This object returns an error advising the user to log in if they attempt to call any method from it.
|
you should replace line 36 of auth.py with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a small fix for #86 but it then became pretty clear that in order to fix that seemingly small issue, most of the app needed a total overhaul. I combined all of the utils functions that shared functionality into a single Drive class, removing an enormous amount of boilerplate code in the process. Added some tests for auth, but this should just be seen as the first step on a long journey to add functionality and reduce waste.