Clarify the deprecation of [Timeout]#1145
Open
Soothsilver wants to merge 1 commit intonunit:masterfrom
Open
Conversation
The new documentation of the [Timeout] attribute introduced two weeks ago states that attribute "doesn't work" but that's not quite accurate, and as evidenced by my own usage and by the usage of others in GitHub items on this project, that partial functionality of the [Timeout] attribute is actively being used, so I would prefer if the documentation described the functionality in more detail as opposed to stating it doesn't work, which may lead readers to mistakenly assume that the [Timeout] attribute does nothing, which isn't true.
SeanKilleen
approved these changes
Mar 5, 2026
Member
SeanKilleen
left a comment
SeanKilleen
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Soothsilver! Looks good to me.
Once you sign the CLA I'll be happy to merge this.
Author
|
@dotnet-policy-service agree company="Microsoft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new documentation of the [Timeout] attribute introduced two weeks ago states that attribute "doesn't work" but that's not quite accurate.
As evidenced by my own usage and by the usage of others in GitHub items on this project, that partial functionality of the [Timeout] attribute is actively being used, so I would prefer if the documentation described the functionality in more detail as opposed to stating it doesn't work, which may lead readers to mistakenly assume that the [Timeout] attribute does nothing, which isn't true.
This PR also updates casing in the article (
.NETinstead of.net).