Skip to content

Doc for adapter defaulttimeout updated #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OsirisTerje merged 1 commit into from
Mar 6, 2026
Merged

Doc for adapter defaulttimeout updated #1142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/articles/vs-test-adapter/Tips-And-Tricks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Certain NUnit Test Adapter settings are configurable using a .runsettings file.
| BasePath | string | path | ? |
| PrivateBinPath | string | directory1;directory2;etc | ? |
| RandomSeed | int | seed integer | random |
| DefaultTimeout | int | timeout in mS, 0 means infinite | 0 |
| DefaultTimeout | int | timeout in mS, 0 means infinite. Not for .net >5.0, error with NUnit 4.5.0 | 0 |
Copy link
Copy Markdown
Member

@SeanKilleen SeanKilleen Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓are we trying to say that both:

  • This is not for .NET 5.0 and greater (e.g. only for .NET core and earlier)
  • ..except for NUnit 4.5.0, when it always throws an error?

I think we need some clarity here and then I can make a suggestion to update the language

Copy link
Copy Markdown
Member Author

@OsirisTerje OsirisTerje Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DefaultTimeout only works for .net framework (and earlier versions of .net core, that is < 5.0, but we don't support that anymore anyway, as we have .net 6 as the lowest currently)

Copy link
Copy Markdown
Member Author

@OsirisTerje OsirisTerje Feb 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeanKilleen Do you have a good way to express this in a short sentence. All my attempts ends up in a long explanation 😫
In NUnit pre 4.5.0, it is silently ignored for .net core > 5.0, but works for .net framework and for those version that support earlier version of .net core than version 5.0.
In NUnit 4.5.0 it fails the test for .net core > 5.0, but works for .net framework.

We could add a description section below, like done for the most of the other properties, where it is explained in details, and keep this short and... ahem.. incomprehensible.

Copy link
Copy Markdown
Member

@SeanKilleen SeanKilleen Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OsirisTerje I tried to turn this over in my head a bunch and I think a description below, with a reference to it here, is the best outcome. You could put a truth table in that description to explain it. Let me know if you want me to take a shot at that.

| [DefaultTestNamePattern](#defaulttestnamepattern) | string | Pattern for display name | {m}{a} |
| [WorkDirectory](#workdirectory) | string | specify directory | Test assembly location |
| [TestOutputXml](#testoutputxml) | string | specify directory | Test Result Xml output folder |
Expand Down