ci: declare contents:read on test_old_cpu workflow#93
Open
arpitjain099 wants to merge 1 commit into
Open
Conversation
The test_old_cpu matrix runs Intel SDE-emulated tests on Sandy Bridge and Haswell baselines. No GitHub API write. contents:read is the floor. Style matches the per-job permissions block in build_wheels.yml (id-token:write for trusted publishing) and the workflow-level shape used by big_endian.yml, build_docs.yml, typecheck.yml. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
Member
|
This workflow is just for testing, so we anyways don't use API tokens here. |
Member
|
My understanding is that this makes sense, although we should maybe set the defaults to be more restrictive to avoid just this type of thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Test on Older CPUs (x86_64-v2)workflow runs an Intel SDE-emulated test matrix against Sandy Bridge and Haswell baselines. It only checks out, downloads SDE, installs system deps, and runs the test suite under emulation. No GitHub API write, no comment-on-PR step.This patch pins it to
permissions: contents: readat workflow scope, matching the per-job block inbuild_wheels.yml(id-token: writefor trusted publishing) and the workflow-level shape used bybig_endian.yml,build_docs.yml, andtypecheck.yml.With explicit scope:
Token-Permissionscheck passes for this fileNo behavioural change.