[Omni] Fix snap selection injection on web pages#83
Merged
Conversation
added 2 commits
May 6, 2026 05:57
by Olga Shen & Omni
by Olga Shen & Omni
by Olga Shen & Omni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the "Failed to start selection mode" error when choosing a select area and clicking Snap Selection. The selection overlay is now injected from
src/background/service-worker.tson demand for valid web pages, avoiding broadhttp://*/*andhttps://*/*host permissions that could complicate Chrome Web Store review. The unusedsrc/content/selection-overlay.tscontent script has been removed.Changes
src/background/service-worker.tsusing runtime script injection.src/content/selection-overlay.tscontent script.vite.config.tsso the removed content script is no longer built.4 files changed, +233 additions, -229 deletions
File changes
Generated by Olga Shen with Omni