Add 1Password formula wrappers for macOS and Linux#124
Merged
Conversation
On macOS, installs the upstream Homebrew casks (1password, 1password-cli) so that `brew upgrade --cask` continues to manage updates. On Linux, configures the official 1Password APT repository and installs packages via apt, preserving `apt upgrade` as the update path. - Formula/onepassword-cli.rb: CLI tool, sets up APT repo on Linux - Formula/onepassword.rb: desktop app, depends on onepassword-cli - Aliases/1password and Aliases/1password-cli for numeric-prefixed names - Updated op-exec.rb dependency to use the new formula https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
…ulas - Align continuation lines to 2-space multiples instead of method-argument alignment - Add 1Password/APT terms (onepassword, dearmor, debsig, keyrings, sourcelist, sourceparts) to cspell dictionary https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
Triggered by: 1bdb413 Workflow run: https://github.com/nsheaps/homebrew-devsetup/actions/runs/23416489932
Casks work on Linux, so the desktop app belongs as a cask that depends on the upstream 1password and 1password-cli casks. The CLI formula remains for Linux APT support (used by op-exec dependency). - Move Formula/onepassword.rb -> Casks/onepassword.rb - Update Aliases/1password symlink to point to cask https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
…p app - macOS: depend on upstream 1password cask (automates the recommended 1password.com download) - Linux: install via APT (1Password's recommended method), reusing the APT repo configured by the onepassword-cli formula - Remove CLI dependency from desktop cask (separate concern) https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
Configure rubocop to use fixed indentation (2-space) for multi-line arguments and operations instead of alignment-based indentation, which produces non-2-space-multiple offsets that editorconfig rejects. https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
Triggered by: ff7fdd9 Workflow run: https://github.com/nsheaps/homebrew-devsetup/actions/runs/23420644195
nsheaps
force-pushed
the
claude/add-1password-install-7z2BD
branch
from
0bd3866 to
49b8261
Compare
Add Layout/LineEndStringConcatenationIndentation cop config to use indented style (2-space) instead of aligned (which produces odd-numbered indentation that editorconfig rejects). Restructure string continuations to start the space on the continuation line to satisfy both linters. https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
Triggered by: 6ef019a Workflow run: https://github.com/nsheaps/homebrew-devsetup/actions/runs/23420796882
- Rename EOS heredoc delimiters to CAVEAT (meaningful name) - Break post_install and setup_apt_repo into smaller methods to stay under rubocop's 10-line method length limit https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
Break 13-line method into two sub-methods under 10 lines each. Verified locally with rubocop: 0 offenses. https://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Homebrew formula wrappers for 1Password and 1Password CLI that delegate installation to native package managers (Homebrew casks on macOS, APT on Linux). These meta-formulas provide a unified installation experience across platforms while leveraging upstream package managers for actual software delivery.
Key Changes
New
onepassword-cliformula: Meta-formula that installs 1Password CLI viabrew caskon macOS or APT repository on LinuxNew
onepasswordformula: Meta-formula for the main 1Password applicationonepassword-clito ensure CLI is availableFormula aliases: Added
1passwordand1password-clialiases pointing to their respective formula files for convenienceUpdated
op-execdependency: Changed from generic1password-clitonsheaps/devsetup/onepassword-clito reference the new formulaImplementation Details
post_installhookshttps://claude.ai/code/session_01BV8yJX7EgQGWUntp1PgDr9