Skip to content

fix: repo stars button should take you to repo homepage for now#3071

Open
juninhokaponne wants to merge 3 commits into
npmx-dev:mainfrom
juninhokaponne:feat/3069-redirect-stargazers-page
Open

fix: repo stars button should take you to repo homepage for now#3071
juninhokaponne wants to merge 3 commits into
npmx-dev:mainfrom
juninhokaponne:feat/3069-redirect-stargazers-page

Conversation

@juninhokaponne

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#3069

🧭 Context

The link to GitHub stars on the package pages pointed to a URL that returned a 404 error.

The reason was that GitHub recently introduced changes affecting some public UI endpoints.

📚 Description

Now, the user is redirected straight to the repository's main page.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 23, 2026 2:16pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 23, 2026 2:16pm
npmx-lunaria Ignored Ignored Jul 23, 2026 2:16pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d0e47d4-2dfc-4a1e-bf74-86fe44cb77dd

📥 Commits

Reviewing files that changed from the base of the PR and between de201fc and 7875fff.

📒 Files selected for processing (2)
  • app/composables/useRepoMeta.ts
  • test/nuxt/components/OgImagePackage.spec.ts
💤 Files with no reviewable changes (2)
  • app/composables/useRepoMeta.ts
  • test/nuxt/components/OgImagePackage.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the repository stars link shown on package pages to use the correct repository URL.
    • Updated stars link behaviour so the “stars” command-palette action and the on-page stars entry only appear when repository linking data is available.
  • Tests
    • Adjusted the Og image package component tests to match the updated repository link fields.

Walkthrough

The repository metadata composable removes starsLink. Package external-links navigation and rendering now use repoLink, and the related test mock reflects the updated composable shape.

Changes

Repository links

Layer / File(s) Summary
Repository metadata link contract
app/composables/useRepoMeta.ts
The composable removes starsLink while retaining repoLink and other repository link fields.
Stars link consumers
app/components/Package/ExternalLinks.vue, test/nuxt/components/OgImagePackage.spec.ts
The command-palette and rendered stars links use repoLink, and the test mock removes starsLink.

Possibly related PRs

Suggested reviewers: ghostdevv

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change to send the stars button to the repository homepage.
Description check ✅ Passed The description is directly related and explains the 404 issue and the redirect to the repo page.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Package/ExternalLinks.vue 50.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/components/Package/ExternalLinks.vue`:
- Around line 11-19: Update the command-palette stars action to check and use
repoLink instead of starsLink, matching the rendered stars item while preserving
the existing action behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6f2268e4-17d3-47d9-9679-06b0e9cacbe1

📥 Commits

Reviewing files that changed from the base of the PR and between bde3efc and 2a5a8d9.

📒 Files selected for processing (1)
  • app/components/Package/ExternalLinks.vue

Comment thread app/components/Package/ExternalLinks.vue Outdated
@ghostdevv ghostdevv changed the title feat: redirect directly to the repo fix: repo stars button should take you to repo homepage for now Jul 22, 2026

@ghostdevv ghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check the code rabbit review. you can also likely remove the starsLink thing from useRepoMeta as we can always revert this in the unlikely event GH reverses course

@juninhokaponne

Copy link
Copy Markdown
Contributor Author

could you check the code rabbit review. you can also likely remove the starsLink thing from useRepoMeta as we can always revert this in the unlikely event GH reverses course

Done! I also removed starsLink from useRepoMeta, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants