Skip to content

fix(i18n): add missing Chinese translations#2521

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
ZHYxulei:main
Apr 14, 2026
Merged

fix(i18n): add missing Chinese translations#2521
ghostdevv merged 2 commits intonpmx-dev:mainfrom
ZHYxulei:main

Conversation

@ZHYxulei
Copy link
Copy Markdown
Contributor

🔗 Linked issue

No linked issue

🧭 Context

This PR updates the Chinese locale file used by npmx. It adds missing translation strings for the settings page and package metadata labels in zh-CN.json.

📚 Description

Added translation for enable_code_ligatures
Added translations for GitHub-related package metadata labels:

githubStars
githubIssues
createdAt

These changes are translation-only and do not affect application logic

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev (canary) Ready Ready Preview, Comment Apr 14, 2026 5:03pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 14, 2026 5:03pm
npmx-lunaria Ignored Ignored Apr 14, 2026 5:03pm

Request Review

@github-actions
Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @ZHYxulei! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

📝 Walkthrough

Walkthrough

Chinese language translations in the i18n locale file have been updated. An existing keyboard shortcuts setting translation was modified, a new code ligatures setting translation was added, and compare facets translations were extended with GitHub stars, issues, and creation date entries.

Changes

Cohort / File(s) Summary
Settings translations
i18n/locales/zh-CN.json
Modified existing settings.keyboard_shortcuts_enabled_description translation and added new settings.enable_code_ligatures key with label and description.
Compare facets translations
i18n/locales/zh-CN.json
Extended compare.facets.items with three new facet keys: githubStars, githubIssues, and createdAt, each with corresponding label and description strings.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset, detailing the addition of Chinese translations for enable_code_ligatures and GitHub-related metadata labels.
Title check ✅ Passed The title accurately reflects the main change—adding missing Chinese translations to the locale file for new UI features and package metadata labels.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ZHYxulei ZHYxulei changed the title Update Chinese translations chore(i18n): update Chinese translations Apr 14, 2026
@ghostdevv ghostdevv changed the title chore(i18n): update Chinese translations fix(i18n): add missing Chinese translations Apr 14, 2026
@ghostdevv ghostdevv added this pull request to the merge queue Apr 14, 2026
Merged via the queue into npmx-dev:main with commit 85333b0 Apr 14, 2026
21 checks passed
@github-actions
Copy link
Copy Markdown

Thanks for your first contribution, @ZHYxulei! ⭐

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

@github-actions github-actions bot mentioned this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants