Skip to content

fix: change default sorting to downloads-week-desc as in parseSortOption #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t128n wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: change default sorting to downloads-week-desc as in parseSortOption #2477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
943660b
fix: change default sorting to downloads-week-desc as in parseSortOption
t128n Apr 11, 2026
f34bac3
fix: change sorting method in org-change watch
t128n Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/pages/org/[org].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const {
setSort,
} = useStructuredFilters({
packages,
initialSort: (normalizeSearchParam(route.query.sort) as SortOption) ?? 'updated-desc',
initialSort: (normalizeSearchParam(route.query.sort) as SortOption) ?? 'downloads-week-desc',
})
Comment on lines 58 to 61
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Apr 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use parseSortOption (not a direct cast) for query-derived sort.

(normalizeSearchParam(route.query.sort) as SortOption) trusts arbitrary query input. An invalid ?sort= value can enter state and bypass the normal defaulting/parsing behaviour described in the PR objective.

Suggested fix 
-import type { FilterChip, SortOption } from '#shared/types/preferences'
+import { parseSortOption, type FilterChip, type SortOption } from '#shared/types/preferences'
@@
-  initialSort: (normalizeSearchParam(route.query.sort) as SortOption) ?? 'downloads-week-desc',
+  initialSort: parseSortOption(normalizeSearchParam(route.query.sort)),

As per coding guidelines: "Ensure you write strictly type-safe code."

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
} = useStructuredFilters({
packages,
initialSort: (normalizeSearchParam(route.query.sort) as SortOption) ?? 'updated-desc',
initialSort: (normalizeSearchParam(route.query.sort) as SortOption) ?? 'downloads-week-desc',
})
} = useStructuredFilters({
packages,
initialSort: parseSortOption(normalizeSearchParam(route.query.sort)),
})


// Pagination state
Expand Down Expand Up @@ -86,7 +86,7 @@ const updateUrl = debounce((updates: { filter?: string; sort?: string }) => {
query: {
...route.query,
q: updates.filter || undefined,
sort: updates.sort && updates.sort !== 'updated-desc' ? updates.sort : undefined,
sort: updates.sort && updates.sort !== 'downloads-week-desc' ? updates.sort : undefined,
},
})
}, 300)
Expand All @@ -112,7 +112,7 @@ const totalWeeklyDownloads = computed(() =>
// Reset state when org changes
watch(orgName, () => {
clearAllFilters()
setSort('updated-desc')
setSort('downloads-week-desc')
currentPage.value = 1
})

Expand Down
Loading