feat: add package name copy button with package manager dropdown icon on search view#2474
feat: add package name copy button with package manager dropdown icon on search view#2474akadotsh wants to merge 1 commit intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Package/Card.vue component has been updated to add a copy-to-clipboard button for package names. A new computed property Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ghostdevv
left a comment
There was a problem hiding this comment.
thanks for the PR! I think the copy button should be always visible to the right of the package name, perhaps just the icon - there was an issue or comment about this for the ones we have already but I can't find it (other than #776) - what do you think?
| <NuxtLink | ||
| :to="packageRoute(result.package.name)" | ||
| :prefetch-on="prefetch ? 'visibility' : 'interaction'" | ||
| class="decoration-none after:content-[''] after:absolute after:inset-0" |
There was a problem hiding this comment.
The logic that the entire card should be clickable seems not to work now. I think this is a more important feature on the search page than copying a name.
The copy button on the side will probably fix this (but it will create an extra interaction)
Could you please share, what user case would this might solve? I feel like user know the name they're looking for in the search already and then open the needed package and interact there
🔗 Linked issue
Closes #2341
🧭 Context
Adds a copy-to-clipboard feature for package names in the search results view.