Skip to content

fix: avoid showing "No README is available" during README load #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akadotsh wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

fix: avoid showing "No README is available" during README load #2473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ if (import.meta.server) {
}

// Fetch README for specific version if requested, otherwise latest
const { data: readmeData } = useLazyFetch<ReadmeResponse>(
const { data: readmeData, status: readmeStatus } = useLazyFetch<ReadmeResponse>(
() => {
const base = `/api/registry/readme/${packageName.value}`
const version = resolvedVersion.value
Expand Down Expand Up @@ -1040,7 +1040,10 @@ const showSkeleton = shallowRef(false)

<!-- eslint-disable vue/no-v-html -- HTML is sanitized server-side -->
<Readme v-if="readmeData?.html" :html="readmeData.html" />
<p v-else class="text-fg-muted italic">
<p
v-else-if="readmeStatus === 'success' && !readmeData?.html"
class="text-fg-muted italic"
>
{{ $t('package.readme.no_readme') }}
<a
v-if="repositoryUrl"
Expand Down
Loading