Skip to content

fix(ui): file tree scroll position is stable when browsing #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhroemer wants to merge 6 commits into
base: main
Choose a base branch
from
+10 −0
Open

fix(ui): file tree scroll position is stable when browsing #2288

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91e0de7
Package code view: file tree scroll position is stable when browsing
jhroemer Mar 26, 2026
c5b0b66
Fix comment
jhroemer Mar 26, 2026
add5bd1
improve sidebar element naming
jhroemer Mar 27, 2026
c4481e8
Ensure scroll position is reset when package + version is changed
jhroemer Mar 27, 2026
6018f65
make sure filetree does not re-render when browsing files only
jhroemer Apr 9, 2026
4fc9ebf
cleanup
jhroemer Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ definePageMeta({
// '/code/@:org?/:packageName/v/:version/:filePath(.*)?',
],
scrollMargin: 160,
// needed to keep the file-tree in-place when navigating files (otherwise the filetree scroll position snaps to the top)
// changing the version (or org/packageName for that matter) causes a re-render
key: route => {
const { org, packageName, version } = route.params as {
org?: string
packageName: string
version: string
}
return `/package-code/${org ?? ''}/${packageName}/v/${version}`
},
})

const route = useRoute('code')
Expand Down
Loading