Skip to content

Conversation

@userquin
Copy link
Contributor

@userquin userquin commented Feb 11, 2026

This PR adds a11y page and missing entries:

missing entries
  • footer.keyboard_shortcuts
  • shortcuts.section.global
  • shortcuts.section.search
  • shortcuts.section.package
  • shortcuts.focus_search
  • shortcuts.show_kbd_hints
  • shortcuts.settings
  • shortcuts.compare
  • shortcuts.compare_from_package
  • shortcuts.navigate_results
  • shortcuts.go_to_result
  • shortcuts.open_code_view
  • shortcuts.open_docs
  • search.found_packages_sorted
  • search.rate_limited
  • search.algolia_disclaimer
  • settings.sections.search
  • settings.data_source.label
  • settings.data_source.description
  • settings.data_source.npm
  • settings.data_source.npm_description
  • settings.data_source.algolia
  • settings.data_source.algolia_description
  • package.security_downgrade.title
  • package.security_downgrade.description_to_none_provenance
  • package.security_downgrade.description_to_none_trustedPublisher
  • package.security_downgrade.description_to_provenance_trustedPublisher
  • package.security_downgrade.fallback_install_provenance
  • package.security_downgrade.fallback_install_trustedPublisher
  • package.security_downgrade.provenance_link_text
  • package.security_downgrade.trusted_publishing_link_text
  • package.versions.distribution_title
  • package.versions.distribution_modal_title
  • package.versions.grouping_major
  • package.versions.grouping_minor
  • package.versions.recent_versions_only
  • package.versions.recent_versions_only_tooltip
  • package.versions.show_low_usage
  • package.versions.show_low_usage_tooltip
  • package.versions.date_range_tooltip
  • package.trends.legend_estimation
  • package.trends.no_data
  • package.trends.y_axis_label
  • package.trends.facet
  • package.trends.title
  • package.trends.items.downloads
  • package.trends.items.likes
  • package.downloads.modal_title
  • package.vulnerabilities.fixed_in_title
  • auth.modal.default_input_error
  • compare.facets.trends.title
  • a11y.title
  • a11y.footer_title
  • a11y.welcome
  • a11y.approach.title
  • a11y.approach.p1
  • a11y.approach.p2
  • a11y.approach.about_link
  • a11y.measures.title
  • a11y.measures.p1
  • a11y.measures.li1
  • a11y.measures.li2
  • a11y.measures.li3
  • a11y.measures.li4
  • a11y.measures.li5
  • a11y.measures.li6
  • a11y.limitations.title
  • a11y.limitations.p1
  • a11y.contact.title
  • a11y.contact.p1
  • a11y.contact.link

I need to review:

  • search.found_packages_sorted and
  • search.algolia_disclaimer

/cc @mrcego

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 2:01pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 2:01pm
npmx-lunaria Ignored Ignored Feb 11, 2026 2:01pm

Request Review

@github-actions
Copy link

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/es-419.json Localization changed, will be marked as complete.
lunaria/files/es-ES.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

This pull request adds and expands internationalisation keys across Spanish locale files (es-419.json, es.json, and corresponding lunaria files). The changes introduce new locale entries for keyboard shortcuts, authentication validation messaging, accessibility content, search functionality enhancements, data source selection settings, version distribution information, and vulnerability trend visualisation. The shortcuts section expands from an empty object to include structured content with global, search, and package categories. Additional keys are added for error messaging, UI labels, and comprehensive accessibility-related documentation.

Possibly related PRs

  • chore(i18n): add missing pl-PL translations #1373: Adds and expands the same i18n key structures including footer.keyboard\_shortcuts, shortcuts.section, search filtering options, settings.data\_source, a11y content, and auth.modal.default\_input\_error across locale files.
  • feat(i18n): update zh-TW translations #1314: Modifies locale JSONs to introduce the same new i18n keys for keyboard shortcuts, expanded shortcuts.section, search-related entries, settings.data\_source, trends and downloads metadata, a11y content, and authentication form validation.
  • fix(i18n): update norwegian translation #1263: Introduces the same localisation key structures including shortcuts section expansion, search entries, settings.data\_source, auth.modal.default\_input\_error, and extensive a11y and privacy\_policy content across locale schemas.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset. It describes adding Spanish translations for an a11y page and lists the specific missing localization entries being added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@userquin
Copy link
Contributor Author

I'm going to keep these messages listed in review... If someone want to change them

@danielroe danielroe added this pull request to the merge queue Feb 11, 2026
Merged via the queue into npmx-dev:main with commit 8ee3608 Feb 11, 2026
18 checks passed
@userquin userquin deleted the feat-add-a11y-spanish-traslation branch February 11, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants