Skip to content

fix: prevent trends date input from being disabled while typing #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 11, 2026
+6 −2
Merged

fix: prevent trends date input from being disabled while typing #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
982eb8e
fix(trends): prevent date input from being disabled while typing
RYGRIT Feb 11, 2026
9efce42
fix: restrict date input to 4-digit years
RYGRIT Feb 11, 2026
a8e6168
Merge remote-tracking branch 'origin/main' into fix/trends-date-inputs
danielroe Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/components/Package/TrendsChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import type {
WeeklyDataPoint,
YearlyDataPoint,
} from '~/types/chart'
import { DATE_INPUT_MAX } from '~/utils/input'

const props = withDefaults(
defineProps<{
Expand Down Expand Up @@ -1452,6 +1453,7 @@ watch(selectedMetric, value => {
v-if="showFacetSelector"
id="trends-metric-select"
v-model="selectedMetric"
:disabled="activeMetricState.pending"
:items="METRICS.map(m => ({ label: m.label, value: m.id }))"
:label="$t('package.trends.facet')"
/>
Expand Down Expand Up @@ -1485,8 +1487,8 @@ watch(selectedMetric, value => {
<InputBase
id="startDate"
v-model="startDate"
:disabled="activeMetricState.pending"
type="date"
:max="DATE_INPUT_MAX"
class="w-full min-w-0 bg-transparent ps-7"
size="medium"
/>
Expand All @@ -1505,8 +1507,8 @@ watch(selectedMetric, value => {
<InputBase
id="endDate"
v-model="endDate"
:disabled="activeMetricState.pending"
type="date"
:max="DATE_INPUT_MAX"
class="w-full min-w-0 bg-transparent ps-7"
size="medium"
/>
Expand Down
2 changes: 2 additions & 0 deletions app/utils/input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,5 @@ export function isKeyWithoutModifiers(event: KeyboardEvent, key: string): boolea
!event.shiftKey
)
}

export const DATE_INPUT_MAX = '9999-12-31'
Loading