Skip to content

fix(ui): view transitions hangs browser instance #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
userquin wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(ui): view transitions hangs browser instance #1278

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6566b1b
fix(ui): view transitions hangs browser instance
userquin Feb 9, 2026
2fd1959
chore: apply coderabbitai suggestion
userquin Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions app/plugins/view-transitions.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,20 @@ export default defineNuxtPlugin(nuxtApp => {
let changeRoute: () => void
const ready = new Promise<void>(resolve => (changeRoute = resolve))

transition = document.startViewTransition(() => {
try {
transition = document.startViewTransition(() => {
changeRoute()
return promise
})

transition.finished.finally(resetTransitionState)
await nuxtApp.callHook('page:view-transition:start', transition)
} catch (err) {
console.error('View Transition failed:', err)
changeRoute!()
return promise
})

transition.finished.then(resetTransitionState)

await nuxtApp.callHook('page:view-transition:start', transition)
finishTransition?.()
resetTransitionState()
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

return ready
})
Expand All @@ -80,7 +86,7 @@ export default defineNuxtPlugin(nuxtApp => {
// Finish when page render completes
nuxtApp.hook('page:finish', () => {
finishTransition?.()
resetTransitionState()
// Do not reset state here, let transition.finished handle it
})
})

Expand Down
Loading