Skip to content

Conversation

@whitep4nth3r
Copy link
Contributor

@whitep4nth3r whitep4nth3r commented Feb 6, 2026

Merge this on 3rd March.

Things to do

Missing a11y tests for 6 component(s):

  • AuthorAvatar.vue
  • AuthorList.vue
  • BlogPostListCard.vue
  • BlogPostWrapper.vue
  • BlueskyComment.vue
  • BlueskyComments.vue

To do before merging

  • delete test posts!

Kai-ros and others added 26 commits January 30, 2026 13:44
I think nuxt prepare will try to compile standard-site-sync and since the
lexicon types don't exist yet it will fail. We should generate the types
first, and then run prepare.
Also add some breathing room to the top of the blog post
This is a WIP. It only runs once on the client when you refresh the page.
- Combined keyboard shortcuts (settings, compare, blog navigation)
- Merged package.json dependencies (kept main versions, added blog dependencies)
- Added presetTypography and presetRtl to uno config
Co-authored-by: Dominik K. <dominik@rivo.gg>
Co-authored-by: Luke Warlow <luke@warlow.dev>
Co-authored-by: Victoria <vicmdo@gmail.com>
Co-authored-by: Yevhen Husak <yev.husak@gmail.com>
Co-authored-by: Yevhen Husak <gusa4grr@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Jialong Lu <48578099+kalu5@users.noreply.github.com>
Co-authored-by: Alexander Schmid <120512287+alexschmd@users.noreply.github.com>
Co-authored-by: James Garbutt <43081j@users.noreply.github.com>
Co-authored-by: Vincent Taverna <vinnymac@gmail.com>
Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
Co-authored-by: Garth de Wet <garthofhearts@gmail.com>
Co-authored-by: Alex Savelyev <91429106+alexdln@users.noreply.github.com>
Co-authored-by: Marcus Blättermann <marcus@essenmitsosse.de>
Co-authored-by: Wojciech Maj <kontakt@wojtekmaj.pl>
Co-authored-by: Chase Naples <cnaples79@gmail.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: btea <2356281422@qq.com>
Co-authored-by: Santosh Yadav <santosh.yadav198613@gmail.com>
Co-authored-by: Vida Xie <vida_2020@163.com>
Co-authored-by: Okinea Dev <hi@okinea.dev>
Co-authored-by: Maher <50132270+abaza738@users.noreply.github.com>
Co-authored-by: Nandkishor Jadoun <183695114+NandkishorJadoun@users.noreply.github.com>
Co-authored-by: abeer0 <47961062+iiio2@users.noreply.github.com>
Co-authored-by: Alec Lloyd Probert <55991794+graphieros@users.noreply.github.com>
Co-authored-by: Stephen Zhou <38493346+hyoban@users.noreply.github.com>
Co-authored-by: Matteo Gabriele <m.gabriele.dev@gmail.com>
Co-authored-by: Mihkel Eidast <mihkel@eida.st>
Co-authored-by: Craig Hart <i@craigary.net>
Co-authored-by: Houssam Elbadissi <skaldebane@gmail.com>
Co-authored-by: Cassidy Williams <1454517+cassidoo@users.noreply.github.com>
Co-authored-by: Cassidy Williams <cassidoo@users.noreply.github.com>
Co-authored-by: Salma Alam-Naylor <52798353+whitep4nth3r@users.noreply.github.com>
Co-authored-by: Bailey Townsend <baileytownsend2323@gmail.com>
Co-authored-by: Denys <40246260+DDeenis@users.noreply.github.com>
Co-authored-by: SHAMIL <64640025+shamilkotta@users.noreply.github.com>
Co-authored-by: Jiří Michel <admin@venty.cz>
Co-authored-by: Lars Kappert <oss@webpro.nl>
Co-authored-by: Jonathan Yeong <hey@jonathanyeong.com>
Co-authored-by: penjj <32674989+penjj@users.noreply.github.com>
Co-authored-by: Nicolas DUBIEN <github@dubien.org>
Co-authored-by: Chris <hizyyv@gmail.com>
Co-authored-by: Josh King <59017897+kn0wn@users.noreply.github.com>
Co-authored-by: Jens Rømer Hesselbjerg <jh.roemer@gmail.com>
Co-authored-by: Nathan Knowler <nathan@knowler.dev>
Co-authored-by: Stanyslas Bres <15731884+sybers@users.noreply.github.com>
Co-authored-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Bobbie Goede <bobbiegoede@gmail.com>
Co-authored-by: Joaquín Sánchez <userquin@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: TAKAHASHI Shuuji <id@shuuji3.xyz>
Co-authored-by: Tierney Cyren <accounts@bnb.im>
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Co-authored-by: Abderrahmen Mhemed <33667872+MhemedAbderrahmen@users.noreply.github.com>
Co-authored-by: abderrahmen.mhemed <abderrahmen.mhemed@wevioo.com>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Roman <dev@rman.dev>
Co-authored-by: shamilkotta <shamilkotta99@gmail.com>
Co-authored-by: rygrit <62373365+RYGRIT@users.noreply.github.com>
Co-authored-by: Vrajpal Jhala <43914725+vrajpal-jhala@users.noreply.github.com>
Co-authored-by: Lars Kappert <lars@webpro.nl>
Co-authored-by: Jaydip Sanghani <91427591+jellydeck@users.noreply.github.com>
Co-authored-by: wr <58406705+onebyte8bits@users.noreply.github.com>
Co-authored-by: wr <wr@wrtekiMacBook-Pro.local>
Co-authored-by: Emanuele Orfanelli <emanueleorfanelli@gmail.com>
Co-authored-by: Robin <robin.kehl@singular-it.de>
Co-authored-by: rzzf <cszhjh@gmail.com>
Co-authored-by: Florian Heuberger <10813063+Flo0806@users.noreply.github.com>
Co-authored-by: Mikołaj Misztal <46728995+mikouaji@users.noreply.github.com>
Co-authored-by: Nico <98180436+nitodeco@users.noreply.github.com>
Co-authored-by: Benjamín Vicente <62021328+benjavicente@users.noreply.github.com>
Co-authored-by: Nico Kempe <50241630+nicokempe@users.noreply.github.com>
Co-authored-by: SerKo <serko.dev@gmail.com>
Co-authored-by: Scott Wu <sw@scottwu.ca>
Co-authored-by: Pascal Küsgen <pascalkuesgen@gmail.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Idris Gadi <85882535+IdrisGit@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 1:00pm
npmx.dev-vercel Ready Ready Preview, Comment Feb 11, 2026 1:00pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 1:00pm
npmx-lunaria Ignored Ignored Feb 11, 2026 1:00pm

Request Review

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
lunaria/files/en-GB.json Localization changed, will be marked as complete. 🔄️
lunaria/files/en-US.json Source changed, localizations will be marked as outdated.
lunaria/files/fr-FR.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
server/api/atproto/bluesky-oembed.get.ts (2)

24-24: Consider defensive handling for regex match despite schema validation.

The non-null assertion and type cast rely on the schema having validated the URL format beforehand. Whilst this is mathematically sound per the comment, the coding guidelines recommend always checking array access by index. A defensive approach would guard against future refactoring that might break this assumption.

🛡️ Optional defensive approach
-      const [, handle, postId] = url.match(BLUESKY_URL_EXTRACT_REGEX)! as [string, string, string]
+      const match = url.match(BLUESKY_URL_EXTRACT_REGEX)
+      if (!match || !match[1] || !match[2]) {
+        throw createError({ statusCode: 400, message: ERROR_BLUESKY_URL_FAILED })
+      }
+      const [, handle, postId] = match

As per coding guidelines: "ensure you always check when accessing an array value by index".


27-32: Consider adding a timeout for the external API call.

The $fetch call to Bluesky's public API could hang if their service is slow or unresponsive. Adding an explicit timeout would improve resilience.

⏱️ Optional timeout configuration
       const { did } = await $fetch<{ did: string }>(
         `${BLUESKY_API}com.atproto.identity.resolveHandle`,
         {
           query: { handle },
+          timeout: 5000,
         },
       )
nuxt.config.ts (1)

93-108: Confirm a one‑year cache is acceptable for registry endpoints.
isr: true plus cache.maxAge of one year could serve stale docs/provenance/files if upstream data changes. If freshness matters, consider a shorter TTL or an explicit isr expiration.

Co-authored-by: Daniel Roe <daniel@roe.dev>
@whitep4nth3r
Copy link
Contributor Author

@jonathanyeong just merged main into this branch, another nightmare

the author avatars are no longer showing on the blog article now and I cannot work out why 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.