Fix crashes, clean up dead code, and fix documentation#1
Closed
Mohammad-Faiz-Cloud-Engineer wants to merge 1 commit into
Closed
Fix crashes, clean up dead code, and fix documentation#1Mohammad-Faiz-Cloud-Engineer wants to merge 1 commit into
Mohammad-Faiz-Cloud-Engineer wants to merge 1 commit into
Conversation
This commit fixes several issues that would cause the app to crash or behave incorrectly:
1. CRASH FIX - No internet: The app needed server settings to run, but if
the internet was off or the server was down, the app would crash. Now
it keeps working using the last saved settings, or shows a helpful
message instead of crashing.
2. CRASH FIX - Settings window: A window where you add passwords/API keys
would crash when opening because of a wrong icon instruction. Fixed it
to match how every other window in the app already works.
3. SPEED IMPROVEMENT - Unnecessary work: A button was secretly redrawing
itself 60 times every second even when untouched. Now it only updates
when you actually hover over it - same look, no wasted work.
4. DOCUMENTATION FIX - Wrong command: The README told users to type
'python main.py' but that file doesn't exist, so it would fail
immediately. Corrected to the real filename.
5. CLEANUP - Removed dead files and unused code:
- Deleted an empty placeholder file (Docs/app.py - was just a blank line)
- Deleted a shopping list for software packages that weren't actually
needed (Docs/requirements.txt)
- Removed 4 lines of imported code that were never used
- Created .gitignore so temporary files don't get accidentally saved
All changes are safe and make the app more reliable.
Member
|
again reveiw it i did some chnages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes several issues that would cause the app to crash or behave incorrectly:
CRASH FIX - No internet: The app needed server settings to run, but if the internet was off or the server was down, the app would crash. Now it keeps working using the last saved settings, or shows a helpful message instead of crashing.
CRASH FIX - Settings window: A window where you add passwords/API keys would crash when opening because of a wrong icon instruction. Fixed it to match how every other window in the app already works.
SPEED IMPROVEMENT - Unnecessary work: A button was secretly redrawing itself 60 times every second even when untouched. Now it only updates when you actually hover over it - same look, no wasted work.
DOCUMENTATION FIX - Wrong command: The README told users to type 'python main.py' but that file doesn't exist, so it would fail immediately. Corrected to the real filename.
CLEANUP - Removed dead files and unused code:
All changes are safe and make the app more reliable.