Conversation
The BNF grammar incorrectly showed `pre` and `build` as identical rules, but they have different requirements per SemVer 2.0.0 specification: - Prerelease identifiers: numeric parts must not have leading zeros (e.g., `1.2.3-00` is invalid, `1.2.3-0` is valid) - Build metadata: allows any alphanumeric string including leading zeros (e.g., `1.2.3+00` is valid) This updates the BNF in both README.md and range.bnf to correctly reflect the implementation behavior and SemVer spec. Fixes npm#665 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Had to go back and double check a few things there, just to be sure.. Yep, leading |
wraithgar
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The BNF grammar in
README.mdandrange.bnfincorrectly definedpreandbuildas identical rules (parts), but they have different requirements per the SemVer 2.0.0 specification:Current behavior (correctly implemented, but BNF was wrong)
Changes
Updates the BNF grammar to distinguish between:
prepart- usesnr(no leading zeros) oralphanumid(alphanumeric identifier)buildid- any alphanumeric string including leading zerosAlso adds an explanatory note after the BNF block to clarify the distinction.
Fixes #665
Test plan