fix(arborist): handle links with cleared targets - #9820
Open
ljepson wants to merge 1 commit into
Open
Conversation
ljepson
marked this pull request as draft
July 29, 2026 16:52
ljepson
force-pushed
the
pr/stale-link-matches
branch
3 times, most recently
from
July 30, 2026 19:20
87a13ec to
5d43dc1
Compare
ljepson
marked this pull request as ready for review
July 30, 2026 19:32
ljepson
force-pushed
the
pr/stale-link-matches
branch
2 times, most recently
from
August 17, 2026 22:24
60b2c44 to
80e1de2
Compare
Reassigning a node's root clears `target` on every link pointing at it, leaving a link with `isLink` true but no target. Comparing such a link in `matches()` crashed with `TypeError: Cannot read properties of null (reading 'matches')`. A link whose target was detached still knows the realpath it pointed at, so fall back to comparing realpaths. Two such links then give the same answer they gave before their targets were cleared, instead of reporting a spurious mismatch.
ljepson
force-pushed
the
pr/stale-link-matches
branch
from
August 17, 2026 23:06
80e1de2 to
7589245
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hit this reifying a pnpm-shaped
node_modules, npm died with:TypeError: Cannot read properties of null (reading 'matches') out of Node.matches()Reassigning a node's root clears target on every link pointing at it, so you can end up with a link where
isLinkis true but target isnull.matches()dereferenced it. Guarding both sides makes a targetless link just not match, which is what the caller wanted anyway. Test builds two links to a shared target and reassigns the target's root to clear both. It throws without the fix.I left the guard inside the existing
this.isLinkbranch rather than restructuring, a plainNodecompared against aLinkstill falls through the same way, so placement and dedupe are untouched.