Open
Conversation
wraithgar
force-pushed
the
gar/allow-git-fix
branch
from
6bab875 to
23d9832
Compare
|
Seems like maybe there's a sketchy test here as well - https://github.com/npm/cli/pull/8943/changes#diff-8ab375e634149f489e0f560b62170ee8770114b25f0d314c83e0493c5b2bf02bR259 |
Member
Author
|
The test was fine, it's a negative test (i.e. refuses a situation). There is no positive test (i.e. allows the situation) and that's what would have caught this. |
Even if it's a negative test, it doesn't actually set 
|
|
In any case, thank you for addressing this issue so quickly! Appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #9189