Skip to content

Do not list sockets using shell mode #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eirvandelden wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Do not list sockets using shell mode #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a826f
Add error messages to Debug Console when rdbg exits
eirvandelden Apr 19, 2024
1c10c93
Fix #6 rdbg not listing sockets, by disabling running as shell
eirvandelden Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Scripts/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ exports.resolveRdbgPath = async function() {
})

process.onDidExit((status) => {
if (status == 1) reject(err)
if (status == 1) {
console.error("An error occured while determining `rdbg` path.")
reject(err)
}

str = str.trim()
if (str.length == 0 || str == "rdbg not found") {
Expand All @@ -39,7 +42,7 @@ exports.resolveRubyDebugSocketPath = async function() {
cwd: nova.workspace.path,
args: ["rdbg", "--util=list-socks"],
stdio: ["ignore", "pipe", "pipe"],
shell: true
shell: false
})

let str = ""
Expand All @@ -54,7 +57,10 @@ exports.resolveRubyDebugSocketPath = async function() {
})

process.onDidExit((status) => {
if (status == 1) reject(err)
if (status == 1) {
console.error("An error occured while determining open rdbg sockets.")
reject(err)
}

str = str.trim()
if (str.length == 0) {
Expand Down Expand Up @@ -92,7 +98,10 @@ exports.generateRubyDebugSocketPath = async function() {
})

process.onDidExit((status) => {
if (status == 1) reject(err)
if (status == 1) {
console.error("An error occured whyle generating rdbg socket.")
reject(err)
}

str = str.trim()
if (str.length == 0) {
Expand Down