fix(interceptors): cache() and deduplicate() silently inert on Client/Pool without opts.origin - #5628
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5628 +/- ##
==========================================
- Coverage 93.50% 93.50% -0.01%
==========================================
Files 110 110
Lines 38455 38467 +12
==========================================
+ Hits 35959 35969 +10
- Misses 2496 2498 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
cache()ordeduplicate()interceptors are composed onto aClientorPooldirectly (not viaAgent),opts.originis not set. Both interceptors useopts.originas the cache/dedup key without fallback — silently falling back to an empty string, making all requests share a single broken key and effectively disabling the interceptors.Fix
Added
getEffectiveOrigin()helper inlib/util/cache.jsthat derives origin fromopts.originor falls back to reconstructing it fromopts.path. Bothcache.jsanddeduplicate.jsuse this helper.Tests
Added
test/interceptors/interceptors-on-client.js— 4 tests, all pass.