fix(cache): Cache.add() and Cache.addAll() hang for responses with bodies - #5627
Open
marko1olo wants to merge 1 commit into
Open
fix(cache): Cache.add() and Cache.addAll() hang for responses with bodies#5627marko1olo wants to merge 1 commit into
marko1olo wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5627 +/- ##
==========================================
+ Coverage 93.50% 93.86% +0.35%
==========================================
Files 110 110
Lines 38455 38484 +29
==========================================
+ Hits 35959 36122 +163
+ Misses 2496 2362 -134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cache.add()andCache.addAll()deadlock when the response has a body: the spec requires the implementation to read the response body before storing it, but the current code never drains the original stream, so the promise never settles.Fix
Clone the response before storing (so the original body can be consumed independently), and explicitly drain the original stream after the clone is created.
Tests
Added
test/cache/cache-add-body.js— all pass (node --test test/cache/cache-add-body.js).