Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4878 +/- ##
==========================================
- Coverage 93.02% 92.90% -0.13%
==========================================
Files 112 113 +1
Lines 35287 35779 +492
==========================================
+ Hits 32827 33239 +412
- Misses 2460 2540 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
left a comment
There was a problem hiding this comment.
Please add TS types and documentation for it
|
@metcoder95 what about the documentation?? |
|
can you add documentation for the new interceptor? |
|
i added ts types and documentation along with limiting the priorities with const PRIORITIES = {
HIGHEST: 4,
HIGH: 3,
MEDIUM: 2,
LOW: 1,
LOWEST: 0
} |
|
the test ci failure is likely a timeout or connection issue on the ci runner |
metcoder95
left a comment
There was a problem hiding this comment.
did you push your changes? Current state of the PR hints otherwise
78a1563 to
a7e2c71
Compare
|
@metcoder95 actually i forgot to push the changes, as i was amending them to the previous commit, completely my fault. now you can review the changes, i pushed them now perfectly |
This relates to...
closes / fixes #4766
Rationale
Changes
added priority interceptor with:
Features
this can be used like the foll code:
Bug Fixes
n/a
Breaking Changes and Deprecations
NA
Status
added tests