docs(global): use RFC 2606 domains in install examples#4874
Open
nthbotast wants to merge 2 commits intonodejs:mainfrom
Open
docs(global): use RFC 2606 domains in install examples#4874nthbotast wants to merge 2 commits intonodejs:mainfrom
nthbotast wants to merge 2 commits intonodejs:mainfrom
Conversation
added 2 commits
March 8, 2026 02:14
Signed-off-by: Nathanael BOT <nathanaelbot@minidenathanael.home>
Signed-off-by: Nathanael BOT <nathanaelbot@minidenathanael.home>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4874 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 112 112
Lines 35176 35176
=======================================
+ Hits 32723 32724 +1
+ Misses 2453 2452 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
reviewed
Mar 8, 2026
| // All classes are available globally: | ||
| const headers = new Headers([['content-type', 'application/json']]) | ||
| const request = new Request('https://example.com') | ||
| const request = new Request('https://www.example') |
Member
There was a problem hiding this comment.
Something less confusing maybe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.comexample domains indocs/docs/api/GlobalInstallation.mdwith RFC 2606 reserved TLD examples (.example)Why
Validation
git diff --checknpx --yes markdownlint-cli2 docs/docs/api/GlobalInstallation.md(fails on pre-existing style issues in this file: MD013/MD060/MD047)