Skip to content

webidl: access keys in lexicographical order#4841

Merged
KhafraDev merged 2 commits intonodejs:mainfrom
KhafraDev:webidl-dict-lexicographical-order
Feb 26, 2026
Merged

webidl: access keys in lexicographical order#4841
KhafraDev merged 2 commits intonodejs:mainfrom
KhafraDev:webidl-dict-lexicographical-order

Conversation

@KhafraDev
Copy link
Member

@KhafraDev
Copy link
Member Author

KhafraDev commented Feb 25, 2026

npm issues? All of the failing runs are giving similar errors to

npm error code E403
npm error 403 403 Forbidden - GET https://registry.npmjs.org/@babel%2fhelper-compilation-targets
npm error 403 In most cases, you or one of your dependencies are requesting
npm error 403 a package version that is forbidden by your security policy, or
npm error 403 on a server you do not have access to.
npm error A complete log of this run can be found in: C:\npm\cache\_logs\2026-02-25T18_50_58_136Z-debug-0.log

(for multiple packages, not just this one)

@Ethan-Arrowood
Copy link
Collaborator

yes, npm was down earlier today.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.14%. Comparing base (088f72c) to head (3d95c4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4841      +/-   ##
==========================================
- Coverage   93.15%   93.14%   -0.02%     
==========================================
  Files         109      109              
  Lines       34228    34231       +3     
==========================================
- Hits        31884    31883       -1     
- Misses       2344     2348       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev KhafraDev merged commit 85cde5d into nodejs:main Feb 26, 2026
48 of 65 checks passed
@KhafraDev KhafraDev deleted the webidl-dict-lexicographical-order branch February 26, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants