Skip to content

fix(websocket): handle WebSocketStream connection failure#4733

Closed
mcollina wants to merge 2 commits intomainfrom
fix-websocketstream-connection-failure
Closed

fix(websocket): handle WebSocketStream connection failure#4733
mcollina wants to merge 2 commits intomainfrom
fix-websocketstream-connection-failure

Conversation

@mcollina
Copy link
Copy Markdown
Member

Fixes #4732

When WebSocketStream fails to connect, return early after rejecting promises to avoid accessing undefined properties.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (3388513) to head (39bb4b1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4733      +/-   ##
==========================================
+ Coverage   92.94%   93.22%   +0.27%     
==========================================
  Files         109      109              
  Lines       33981    33985       +4     
==========================================
+ Hits        31584    31681      +97     
+ Misses       2397     2304      -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina requested a review from KhafraDev January 19, 2026 21:53
mcollina and others added 2 commits January 19, 2026 17:43
@KhafraDev KhafraDev force-pushed the fix-websocketstream-connection-failure branch from 5813e51 to 39bb4b1 Compare January 19, 2026 22:44
KhafraDev
KhafraDev previously approved these changes Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebSocketStream throws internal error when cannot open an connection

3 participants