Skip to content

chore: fix prettier - #994

Open
avivkeller wants to merge 1 commit into
mainfrom
prettier
Open

chore: fix prettier#994
avivkeller wants to merge 1 commit into
mainfrom
prettier

Conversation

@avivkeller

Copy link
Copy Markdown
Member

As titled

@avivkeller
avivkeller requested a review from a team as a code owner August 3, 2026 15:23
Copilot AI review requested due to automatic review settings August 3, 2026 15:23
@cursor

cursor Bot commented Aug 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Formatting-only edits to generated Worker typings and JSONC config; no logic, deployment routes, or env values change.

Overview
Applies Prettier formatting with no intended runtime or type behavior changes.

In worker-configuration.d.ts, multi-line union aliases are collapsed onto single lines (e.g. ValueType, HeadersInit, R2 put value types, AI model input unions, workflow duration types). The Console assert member is updated from a quoted 'assert' key to assert.

In wrangler.jsonc, a trailing comma is added after the staging route entry in the routes array.

Reviewed by Cursor Bugbot for commit df46e25. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR applies Prettier-driven formatting fixes to the Cloudflare Worker configuration and the generated/checked-in TypeScript declaration file to align with consistent code style.

Changes:

  • Add a trailing comma / normalize formatting in wrangler.jsonc for the routes array entry.
  • Reformat TypeScript declarations in worker-configuration.d.ts (e.g., unquoted method name and condensed union types).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
wrangler.jsonc Adjusts JSONC formatting (adds trailing comma) to satisfy Prettier/style expectations.
worker-configuration.d.ts Applies Prettier formatting to declaration syntax (method name and union/mapped type formatting).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread worker-configuration.d.ts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated, I don't think it should be formatted? I'm not sure why it is even checked in?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "official" recommendation is to check it in, which is why it's here, but I'm more in favor of just removing it now and adding a step in the contributing guideline saying to generate it yourself

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just add it as a prepare script, so it happens whenever deps get installed locally?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants