tools: fix the list of globals in ESLint config files - #65281
Open
aduh95 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot
added
needs-ci
1 task
MikeMcC399
reviewed
Aug 14, 2026
MikeMcC399
reviewed
Aug 14, 2026
MikeMcC399
reviewed
Aug 14, 2026
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
cjihrig
approved these changes
Aug 14, 2026
aduh95
added
author ready
lpinca
approved these changes
Aug 14, 2026
anonrig
approved these changes
Aug 14, 2026
legendecas
approved these changes
Aug 14, 2026
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65281 ✔ Done loading data for nodejs/node/pull/65281 ----------------------------------- PR info ------------------------------------ Title tools: fix the list of globals in ESLint config files (#65281) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-globals -> nodejs:main Labels tools, author ready, needs-ci, commit-queue, commit-queue-squash Commits 2 - tools: fix the list of globals in ESLint config files - squash! fix typo Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/65281 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65281 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Aug 2026 08:52:23 GMT ✔ Approvals: 4 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65281#pullrequestreview-4937011700 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/65281#pullrequestreview-4937868624 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/65281#pullrequestreview-4938070764 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/65281#pullrequestreview-4940627512 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/31937660121 |
Member
|
This needs a rebase |
trivikr
removed
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #64894 (comment), we were missing some entries. I also took the liberty of reordering the list in ASCII order as there were only a few items out of order.