Skip to content

stream: simplify nested PromisePrototypeThens#64470

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:then-chains-in-adapters.js
Open

stream: simplify nested PromisePrototypeThens#64470
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:then-chains-in-adapters.js

Conversation

@aduh95

@aduh95 aduh95 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No need to complicate them

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.25%. Comparing base (a1e3e6d) to head (e2bc65f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #64470   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files         741      741           
  Lines      241604   241588   -16     
  Branches    45526    45536   +10     
=======================================
+ Hits       218029   218036    +7     
+ Misses      15107    15101    -6     
+ Partials     8468     8451   -17     
Files with missing lines Coverage Δ
lib/internal/webstreams/adapters.js 86.42% <100.00%> (-0.20%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. web streams

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants