Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/internal/streams/iter/consumers.js
Original file line number Diff line number Diff line change
Expand Up @@ -426,8 +426,10 @@ function merge(...args) {
if (normalized.length === 0) return;

if (normalized.length === 1) {
for await (const batch of normalized[0]) {
signal?.throwIfAborted();
const source = signal !== undefined && isAsyncIterable(sources[0]) ?
from(yieldAbortable(sources[0], signal)) :
yieldAbortable(normalized[0], signal);
for await (const batch of source) {
yield batch;
}
return;
Expand Down
5 changes: 4 additions & 1 deletion lib/internal/streams/iter/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ function yieldAbortable(source, signal) {
if (!completed && typeof iterator.return === 'function') {
const result = iterator.return();
if (aborted) {
markPromiseAsHandled(result);
// PromiseResolve(result) can reject if result is a thenable that
// rejects, so mark it as handled even though the abort takes
// precedence over the result of iterator.return().
markPromiseAsHandled(PromiseResolve(result));
Comment thread
trivikr marked this conversation as resolved.
} else {
await result;
}
Expand Down
32 changes: 32 additions & 0 deletions test/parallel/test-stream-iter-consumers-merge.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,37 @@ async function testMergeSignalDuringPendingMultiSourceRead() {
await assert.rejects(next, { name: 'AbortError' });
}

async function testMergeSignalDuringPendingSingleSourceRead() {
const ac = new AbortController();
let returned = false;
const source = {
__proto__: null,
[Symbol.asyncIterator]() {
return this;
},
next() {
// Intentionally never settle to verify that aborting interrupts a pending read.
return new Promise(() => {});
Comment thread
trivikr marked this conversation as resolved.
},
return() {
returned = true;
return { __proto__: null, done: true };
},
};

const iter = merge(source, {
__proto__: null,
signal: ac.signal,
})[Symbol.asyncIterator]();

const next = iter.next();
await new Promise(setImmediate);
ac.abort();

await assert.rejects(next, { name: 'AbortError' });
assert.strictEqual(returned, true);
}

async function testMergeDoesNotDrainSourcesWhileIdle() {
function source(n) {
return {
Expand Down Expand Up @@ -332,6 +363,7 @@ Promise.all([
testMergeConsumerBreak(),
testMergeSignalMidIteration(),
testMergeSignalDuringPendingMultiSourceRead(),
testMergeSignalDuringPendingSingleSourceRead(),
testMergeDoesNotDrainSourcesWhileIdle(),
testMergeStringSources(),
testMergeObjectLikeSources(),
Expand Down
Loading