Skip to content

doc: remove duplicate VirtualProvider description#64400

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Archkon:vfs
Jul 12, 2026
Merged

doc: remove duplicate VirtualProvider description#64400
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Archkon:vfs

Conversation

@Archkon

@Archkon Archkon commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vfs Issues and PRs related to the virtual filesystem subsystem. labels Jul 10, 2026
@Archkon
doc: remove duplicate VirtualProvider description
e7e84b4 
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@Archkon

Archkon commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@deokjinkim
Could you please consider fast-tracking this PR and adding it to the commit queue? I believe the changes are trivial.

@deokjinkim deokjinkim added the fast-track PRs that do not need to wait for 72 hours to land. label Jul 12, 2026
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @deokjinkim. Please 👍 to approve.

@deokjinkim

deokjinkim commented Jul 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@deokjinkim Could you please consider fast-tracking this PR and adding it to the commit queue? I believe the changes are trivial.

I attached fast-track label, but as you might know, we need 2 collaborator's approval to merge for now. With 1 approval, we can merge PR after 1 week.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews

At least two collaborators must approve a pull request before the pull request lands. One collaborator approval is enough if the pull request has been open for more than seven days.

@Archkon Archkon mentioned this pull request Jul 12, 2026
Merged
@Archkon

Archkon commented Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

@deokjinkim Could you please consider fast-tracking this PR and adding it to the commit queue? I believe the changes are trivial.

I attached fast-track label, but as you might know, we need 2 collaborator's approval to merge for now. With 1 approval, we can merge PR after 1 week.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/collaborator-guide.md#code-reviews

At least two collaborators must approve a pull request before the pull request lands. One collaborator approval is enough if the pull request has been open for more than seven days.

OK,Thanks for your reminder

@trivikr trivikr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2026
@nodejs-github-bot nodejs-github-bot merged commit 794d9b1 into nodejs:main Jul 12, 2026
23 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Landed in 794d9b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deokjinkim deokjinkim deokjinkim approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. vfs Issues and PRs related to the virtual filesystem subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Archkon @deokjinkim @nodejs-github-bot @trivikr @mertcanaltin