Skip to content

node-api: add napi_create_external_sharedarraybuffer#62623

Open
bnoordhuis wants to merge 13 commits intonodejs:mainfrom
bnoordhuis:fix62259
Open

node-api: add napi_create_external_sharedarraybuffer#62623
bnoordhuis wants to merge 13 commits intonodejs:mainfrom
bnoordhuis:fix62259

Conversation

@bnoordhuis
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis commented Apr 7, 2026

Creates a SharedArrayBuffer from externally managed memory.

Fixes: #62259

@bnoordhuis
node-api: add napi_create_external_sharedarraybuffer
3b8f808 
Creates a SharedArrayBuffer from externally managed memory.

Fixes: nodejs#62259
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 7, 2026

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Apr 7, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (f48ac91) to head (bfed127).
⚠️ Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
src/js_native_api_v8.cc 72.00% 0 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62623      +/-   ##
==========================================
+ Coverage   89.77%   89.80%   +0.03%     
==========================================
  Files         697      699       +2     
  Lines      215749   216404     +655     
  Branches    41304    41379      +75     
==========================================
+ Hits       193681   194344     +663     
+ Misses      14161    14139      -22     
- Partials     7907     7921      +14
Files with missing lines Coverage Δ
src/js_native_api_v8.cc 76.43% <72.00%> (-0.06%) ⬇️

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 7, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72534/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2026
@ronag ronag requested a review from vmoroz April 7, 2026 14:16
legendecas
legendecas reviewed Apr 7, 2026
View reviewed changes
@legendecas legendecas removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2026
@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Apr 7, 2026
KevinEady
KevinEady reviewed Apr 7, 2026
View reviewed changes
KevinEady
KevinEady reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 7, 2026
View reviewed changes
@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Apr 9, 2026

Review feedback incorporated, PTAL.

legendecas
legendecas approved these changes Apr 9, 2026
View reviewed changes
vmoroz
vmoroz reviewed Apr 10, 2026
View reviewed changes
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72608/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 13, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72672/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@vmoroz vmoroz vmoroz approved these changes

@ronag ronag ronag approved these changes

@legendecas legendecas legendecas approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@addaleax addaleax Awaiting requested review from addaleax

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

+1 more reviewer

@KevinEady KevinEady KevinEady left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Node-API Team Project
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing napi_create_external_sharedarraybuffer

7 participants

@bnoordhuis @nodejs-github-bot @mcollina @vmoroz @ronag @legendecas @KevinEady