readline: support kitty keyboard protocol#62186
Closed
jechol wants to merge 1 commit intonodejs:mainfrom
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62186 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.01%
==========================================
Files 676 676
Lines 206546 206669 +123
Branches 39558 39584 +26
==========================================
+ Hits 185179 185274 +95
- Misses 13485 13517 +32
+ Partials 7882 7878 -4
🚀 New features to boost your workflow:
|
Member
|
@jechol Heya! I hope you don't mind me asking, why did you end up closing this PR? It was something I had earmarked as something I could be a potential reviewer for, just hadn't gotten around to it yet, but it seemed like something we'd potentially find desirable to have in Node.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is intended to address the regression where in the VS Code integrated terminal stops handling keys like Backspace and Ctrl+C correctly once kitty keyboard protocol is enabled. VS Code 1.109 release notes call out that kitty keyboard support is available to all users, which makes the readline/REPL incompatibility user-visible in the default terminal experience.
It is also worth calling out that Node does not need to be the component that explicitly enables kitty mode for this to break. In practice, the terminal host can already have kitty keyboard protocol enabled before starts reading stdin. That is the same compatibility shape discussed in the linked Erlang/OTP thread: the application may receive kitty CSI-u sequences simply because the surrounding terminal environment opted in earlier.
References:
Testing