sea: support code cache for ESM entrypoint in SEA#62158
Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Open
sea: support code cache for ESM entrypoint in SEA#62158joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
joyeecheung
commented
Mar 8, 2026
| // in the SEA code. Support it. | ||
| // Refs: https://github.com/nodejs/node/pull/48191#discussion_r1213271430 | ||
| // TODO(joyeecheung): this likely has been fixed by | ||
| // https://chromium-review.googlesource.com/c/v8/v8/+/5401780 - add a test |
Member
Author
There was a problem hiding this comment.
I noticed that this should already be fixed - and locally it works. But since it was talking about the CommonJS case I think it's out of scope of this PR, so I only left a TODO.
The initial support for ESM entrypoint in SEA didn't support code cache. This patch implements that by following a path similar to how code cache in CJS SEA entrypoint is supported: at build time we generate the code cache from C++ and put it into the sea blob, and at runtime we consume it via a special case in compilation routines - for CJS this was CompileFunctionForCJSLoader, in the case of SourceTextModule, it's in Module::New.
joyeecheung
force-pushed
the
esm-sea-code-cache
branch
from
6e05770 to
57e7b9f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62158 +/- ##
==========================================
- Coverage 89.66% 89.65% -0.01%
==========================================
Files 676 676
Lines 206543 206571 +28
Branches 39542 39552 +10
==========================================
+ Hits 185193 185202 +9
- Misses 13475 13484 +9
- Partials 7875 7885 +10
🚀 New features to boost your workflow:
|
aymen94
approved these changes
Mar 9, 2026
github-actions
bot
removed
the
request-ci
Collaborator
addaleax
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial support for ESM entrypoint in SEA didn't support code cache. This patch implements that by following a path similar to how code cache in CJS SEA entrypoint is supported: at build time we generate the code cache from C++ and put it into the sea blob, and at runtime we consume it via a special case in compilation routines - for CJS this was
CompileFunctionForCJSLoader, in the case of SourceTextModule, it's in Module::New.
Refs: #61813