Open
Conversation
Original commit message:
Fix resb on big endian platforms
Refs: unicode-org/icu4x@d310df8
Refs: unicode-org/icu4x#7658
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dependencies
legendecas
reviewed
Mar 6, 2026
richardlau
added
the
commit-queue-squash
legendecas
approved these changes
Mar 6, 2026
github-actions
bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #61808
Refs: unicode-org/icu4x@d310df8
Refs: unicode-org/icu4x#7658
I'm open to other suggestions about how to patch the vendored crate. This way appears to work, https://ci.nodejs.org/job/node-test-commit-linuxone/53963/ (configured with
--v8-enable-temporal-support). See #61808 for other methods I have tried (unsuccessfully).