quic: guard against null impl_ in UpdateDataStats#62126
Open
zerone0x wants to merge 2 commits intonodejs:mainfrom
Open
quic: guard against null impl_ in UpdateDataStats#62126zerone0x wants to merge 2 commits intonodejs:mainfrom
zerone0x wants to merge 2 commits intonodejs:mainfrom
Conversation
When a QUIC session's handshake fails or the connection is terminated early, UpdateDataStats() can be called before impl_ has been initialized, leading to a null pointer dereference and SIGSEGV. Add an early return when impl_ is nullptr to prevent the crash. Fixes: nodejs#62057 Co-Authored-By: Claude <noreply@anthropic.com>
nodejs-github-bot
added
c++
addaleax
approved these changes
Mar 6, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Can you add a regression test?
Exercises the crash path in Session::SendDataStats() where on_exit fires UpdateDataStats() after Destroy() has already reset impl_ to nullptr. Refs: nodejs#62126
Author
|
added a regression test in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a QUIC session's handshake fails or the connection is
terminated early, `UpdateDataStats()` can be called before `impl_`
has been initialized, leading to a null pointer dereference
and SIGSEGV.
Add an early return when `impl_` is nullptr to prevent the crash.
Fixes: #62057