Skip to content

build: exclude more machines from doc gen#62116

Open
avivkeller wants to merge 1 commit intonodejs:mainfrom
avivkeller:no-doc-on-os390
Open

build: exclude more machines from doc gen#62116
avivkeller wants to merge 1 commit intonodejs:mainfrom
avivkeller:no-doc-on-os390

Conversation

@avivkeller
Copy link
Member

Fixes https://openjs-foundation.slack.com/archives/C09EXEEHFKP/p1772723396007549 by also exclude S390X machines from WASM. See nodejs/build#4258 for more info on the AIX failures, it's fairly similar on S390X.

cc @Renegade334

Copilot AI review requested due to automatic review settings March 5, 2026 15:28
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends an existing workaround that prevents doc generation from running on AIX machines (due to WASM-related hangs during HTML minification) to also apply to z/OS (os390) machines, which share the same problem. This is a build system fix using the standard Make filter idiom to match multiple OSTYPE values in a single conditional.

Changes:

  • Replaced the single-value ifeq check for aix with a multi-value ifneq + filter check covering both aix and os390
  • Updated the associated comment to reflect the expanded scope of the workaround

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Renegade334 Renegade334 added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 5, 2026
@richardlau
Copy link
Member

cc @nodejs/platform-s390

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Fast-track has been requested by @Renegade334. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (1647288) to head (ed45617).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62116      +/-   ##
==========================================
- Coverage   89.64%   89.64%   -0.01%     
==========================================
  Files         676      676              
  Lines      206330   206330              
  Branches    39518    39526       +8     
==========================================
- Hits       184973   184965       -8     
- Misses      13480    13511      +31     
+ Partials     7877     7854      -23     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very happy on simply disabling platforms without understanding what's going wrong. Won't block, but I'm virtually 👎

@Renegade334
Copy link
Member

I'm not very happy on simply disabling platforms without understanding what's going wrong.

I believe Aviv is looking into it, but keeping core CI failing isn't going to help with that objective either. The alternative is reverting 76215dc and removing doc-kit from core while the issue is analysed.

@avivkeller
Copy link
Member Author

I'm not very happy on simply disabling platforms without understanding what's going wrong. Won't block, but I'm virtually 👎

I am, as @Renegade334, going to conduct an investigation. However, given that only two runners are failing, both of which I would consider "niche" (in the context of a runner normally used to build the docs), I do think it's fine to remove them for now.

Currently, my understanding is that:

  • AIX Hangs
  • S390 crashes due to some sort of memory failure.

It's not much to go off at the moment, but I'll be looking into it further.

@ovflowd
Copy link
Member

ovflowd commented Mar 5, 2026

I'm not very happy on simply disabling platforms without understanding what's going wrong.

I believe Aviv is looking into it, but keeping core CI failing isn't going to help with that objective either. The alternative is reverting 76215dc and removing doc-kit from core while the issue is analysed.

I'm not opposed to the PR, just opposed as this being a long-term solution.

@avivkeller
Copy link
Member Author

Ideally, it won't be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants