build: exclude more machines from doc gen#62116
build: exclude more machines from doc gen#62116avivkeller wants to merge 1 commit intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends an existing workaround that prevents doc generation from running on AIX machines (due to WASM-related hangs during HTML minification) to also apply to z/OS (os390) machines, which share the same problem. This is a build system fix using the standard Make filter idiom to match multiple OSTYPE values in a single conditional.
Changes:
- Replaced the single-value
ifeqcheck foraixwith a multi-valueifneq + filtercheck covering bothaixandos390 - Updated the associated comment to reflect the expanded scope of the workaround
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
cc @nodejs/platform-s390 |
|
Fast-track has been requested by @Renegade334. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62116 +/- ##
==========================================
- Coverage 89.64% 89.64% -0.01%
==========================================
Files 676 676
Lines 206330 206330
Branches 39518 39526 +8
==========================================
- Hits 184973 184965 -8
- Misses 13480 13511 +31
+ Partials 7877 7854 -23 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
ovflowd
left a comment
There was a problem hiding this comment.
I'm not very happy on simply disabling platforms without understanding what's going wrong. Won't block, but I'm virtually 👎
I believe Aviv is looking into it, but keeping core CI failing isn't going to help with that objective either. The alternative is reverting 76215dc and removing doc-kit from core while the issue is analysed. |
I am, as @Renegade334, going to conduct an investigation. However, given that only two runners are failing, both of which I would consider "niche" (in the context of a runner normally used to build the docs), I do think it's fine to remove them for now. Currently, my understanding is that:
It's not much to go off at the moment, but I'll be looking into it further. |
I'm not opposed to the PR, just opposed as this being a long-term solution. |
|
Ideally, it won't be. |
Fixes https://openjs-foundation.slack.com/archives/C09EXEEHFKP/p1772723396007549 by also exclude S390X machines from WASM. See nodejs/build#4258 for more info on the AIX failures, it's fairly similar on S390X.
cc @Renegade334