Skip to content

deps: upgrade npm to 10.9.5#62110

Open
npm-cli-bot wants to merge 1 commit intonodejs:v22.x-stagingfrom
npm:npm-v10.9.5-22
Open

deps: upgrade npm to 10.9.5#62110
npm-cli-bot wants to merge 1 commit intonodejs:v22.x-stagingfrom
npm:npm-v10.9.5-22

Conversation

@npm-cli-bot
Copy link
Contributor

10.9.5 (2026-03-04)

Bug Fixes

Dependencies

Chores

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Mar 4, 2026
@wraithgar
Copy link
Contributor

This needs a dont-land-on-v20.x tag please!

@manzoorwanijk
Copy link

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

@ljharb ljharb added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Mar 5, 2026
@Renegade334
Copy link
Member

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

#58847 (comment)

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026
@nodejs-github-bot
Copy link
Collaborator

@wraithgar
Copy link
Contributor

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

npm@10 works just fine in node 20, but we can't update it in releases anymore because of a breaking change in python requirements in node-gyp. Most folks will be able to update on their own without any problems.

@marco-ippolito
Copy link
Member

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

npm@10 works just fine in node 20, but we can't update it in releases anymore because of a breaking change in python requirements in node-gyp. Most folks will be able to update on their own without any problems.

If I understood correctly, a breaking node-gyp upgrade was included in the npm release? Was it a semver major upgrade of node-gyp? I'm trying to understand if its possible to revert the breaking change so users can upgrade npm on node v20 without breaking changes

@richardlau
Copy link
Member

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

npm@10 works just fine in node 20, but we can't update it in releases anymore because of a breaking change in python requirements in node-gyp. Most folks will be able to update on their own without any problems.

If I understood correctly, a breaking node-gyp upgrade was included in the npm release? Was it a semver major upgrade of node-gyp? I'm trying to understand if its possible to revert the breaking change so users can upgrade npm on node v20 without breaking changes

nodejs/node-gyp#3149 introduced the walrus operator (incompatible with Python 3.7 and 3.6) and went out in node-gyp 11.2.0.

@wraithgar
Copy link
Contributor

wraithgar commented Mar 5, 2026

This needs a dont-land-on-v20.x tag please!

Is there any specific requirement for these changes to not work in v20?

npm@10 works just fine in node 20, but we can't update it in releases anymore because of a breaking change in python requirements in node-gyp. Most folks will be able to update on their own without any problems.

If I understood correctly, a breaking node-gyp upgrade was included in the npm release? Was it a semver major upgrade of node-gyp? I'm trying to understand if its possible to revert the breaking change so users can upgrade npm on node v20 without breaking changes

It was not, it was a minor release. It was a part of node-gyp that wasn't really on anyone's radar for checking breaking changes, but it is now. There was even a discussion in the update PR that talked about updating python and nobody clocked it. It was just an oversight that we're now having to deal with.

Folks wanting to use the newest npm@10 in node 20 can still override which node-gyp is used via config. So even for the subset of folks this affects there is a workaround.

@marco-ippolito
Copy link
Member

Could it be possible to revert that breaking change or is it too late/ there are other breaking changes?
If its python syntax I could rewrite it a python 3.6 compatible way and push it in a new node-gyp release

@wraithgar
Copy link
Contributor

wraithgar commented Mar 5, 2026

Could it be possible to revert that breaking change or is it too late/ there are other breaking changes?

I do not know the specifics of if or how node-gyp@10 could be patched but downgrading it in npm itself would likely be a breaking change much larger than the python version issue.

ETA: node 20 goes eol in approximately one month. I don't think large disruptions are warranted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants