http: fix use-after-free when freeParser is called during llhttp_execute#62095
Open
Flarna wants to merge 2 commits intonodejs:mainfrom
Open
http: fix use-after-free when freeParser is called during llhttp_execute#62095Flarna wants to merge 2 commits intonodejs:mainfrom
Flarna wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Flarna
force-pushed
the
http_parser_use_after_free
branch
from
9943149 to
ff06bb7
Compare
Flarna
changed the title
When pipelined requests arrive in one TCP segment, llhttp_execute() parses them all in a single call. If a synchronous 'close' event handler invokes freeParser() mid-execution, cleanParser() nulls out parser state while llhttp_execute() is still on the stack, crashing on the next callback. Add an is_being_freed_ flag that freeParser() sets via parser.markFreed() before cleaning state. Proxy::Raw checks the flag before every callback and returns HPE_USER to abort execution early if set.
Flarna
force-pushed
the
http_parser_use_after_free
branch
from
ff06bb7 to
d2ea166
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62095 +/- ##
==========================================
+ Coverage 89.64% 89.65% +0.01%
==========================================
Files 676 676
Lines 206326 206336 +10
Branches 39528 39527 -1
==========================================
+ Hits 184960 185000 +40
+ Misses 13476 13465 -11
+ Partials 7890 7871 -19
🚀 New features to boost your workflow:
|
Flarna
added
the
author ready
github-actions
bot
removed
the
request-ci
Collaborator
cjihrig
approved these changes
Mar 4, 2026
addaleax
added
the
commit-queue
anonrig
reviewed
Mar 5, 2026
Flarna
removed
the
commit-queue
Flarna
added
the
commit-queue-squash
addaleax
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pipelined requests arrive in one TCP segment, llhttp_execute() parses them all in a single call. If a synchronous 'close' event handler invokes freeParser() mid-execution, cleanParser() nulls out parser state while llhttp_execute() is still on the stack, crashing on the next callback.
Add an is_being_freed_ flag that freeParser() sets via parser.markFreed() before cleaning state. Proxy::Raw checks the flag before every callback and returns HPE_USER to abort execution early if set.
Fix/test was created using AI support.
Refs: #61995 (comment)