test_runner: fix run() none-isolation teardown hang#62056
Closed
inoway46 wants to merge 1 commit intonodejs:mainfrom
Closed
test_runner: fix run() none-isolation teardown hang#62056inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
2e503c7 to
d00a7b1
Compare
d00a7b1 to
c8bf2a8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62056 +/- ##
==========================================
- Coverage 89.65% 89.64% -0.02%
==========================================
Files 676 676
Lines 206543 206549 +6
Branches 39547 39548 +1
==========================================
- Hits 185184 185155 -29
- Misses 13480 13523 +43
+ Partials 7879 7871 -8
🚀 New features to boost your workflow:
|
Member
|
I think this might be a duplicate of #57394 |
Contributor
Author
|
@JakobJingleheimer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
run({ isolation: 'none' })is used from a cluster worker, live handles such as IPC can keep the process open after the tests finish. In that case teardown may be delayed and therun()stream can hang waiting forend.Set an explicit teardown callback for the non-
isTestRunnerrun()path so the stream can finalize even if the process is still being kept alive by open handles.Add a regression test based on the reproduction from #60020.
Fixes: #60020