Skip to content

esm: avoid super-linear data URL MIME regex #61951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skdas20 wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −2
Open

esm: avoid super-linear data URL MIME regex #61951

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06fb2cd
esm: avoid super-linear data URL MIME regex
skdas20 Feb 23, 2026
740d132
test: add regression for data URL format backtracking
skdas20 Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/get_format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ function detectModuleFormat(source, url) {
*/
function getDataProtocolModuleFormat(parsed) {
const { 1: mime } = RegExpPrototypeExec(
/^([^/]+\/[^;,]+)(?:[^,]*?)(;base64)?,/,
/^([^/]+\/[^;,]+)(?:;[^,]*)?,/,
parsed.pathname,
) || [ null, null, null ];

Expand Down
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ function throwIfUnsupportedURLScheme(parsed) {
*/
function throwUnknownModuleFormat(url, format) {
const dataUrl = RegExpPrototypeExec(
/^data:([^/]+\/[^;,]+)(?:[^,]*?)(;base64)?,/,
/^data:([^/]+\/[^;,]+)(?:;[^,]*)?,/,
url,
);

Expand Down